Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update workflow controller initDB func #11760

Merged
merged 1 commit into from
Sep 6, 2023
Merged

chore: Update workflow controller initDB func #11760

merged 1 commit into from
Sep 6, 2023

Conversation

astraw99
Copy link
Contributor

@astraw99 astraw99 commented Sep 6, 2023

Fixes #11177

Motivation

To simplify the workflow controller initDB function.

Modifications

Reduced if else, just return the sqldb.NewMigrate(...).

Verification

After the code modification, tested the workflow-controller deployment in my environment with
multiple replicas (1, 5 and 10), all work ok.

10 for example:

workflow-controller-85bfb69457-292r6   1/1     Running   0          8s
workflow-controller-85bfb69457-5jc6l   1/1     Running   0          7s
workflow-controller-85bfb69457-b2fw2   1/1     Running   0          7s
workflow-controller-85bfb69457-kr4kv   1/1     Running   0          7s
workflow-controller-85bfb69457-lkz9r   1/1     Running   0          8s
workflow-controller-85bfb69457-ms5zf   1/1     Running   0          7s
workflow-controller-85bfb69457-qwcvx   1/1     Running   0          7s
workflow-controller-85bfb69457-sxdjj   1/1     Running   0          7s
workflow-controller-85bfb69457-w8hvr   1/1     Running   0          8s
workflow-controller-85bfb69457-xcd2x   1/1     Running   0          7s

@astraw99
Update workflow controller initDB func
af0a25f 
Signed-off-by: astraw99 <wangchengiscool@gmail.com>
@astraw99 astraw99 mentioned this pull request Sep 6, 2023
Merged
@agilgur5 agilgur5 added the area/controller Controller issues, panics label Sep 6, 2023
@agilgur5 agilgur5 requested a review from Joibel September 6, 2023 14:57
Joibel
Joibel approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, it reads easier. Thank you.

@terrytangyuan terrytangyuan enabled auto-merge (squash) September 6, 2023 16:39
@terrytangyuan terrytangyuan merged commit 595ab4b into argoproj:master Sep 6, 2023
@Joibel Joibel mentioned this pull request Nov 2, 2023
Closed
6 tasks
@Joibel Joibel mentioned this pull request Jan 31, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@Joibel Joibel Joibel approved these changes

Assignees
No one assigned
Labels
area/controller Controller issues, panics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Argo DB init conflict when deploy workflow-controller with multiple replicas
4 participants
@astraw99 @Joibel @terrytangyuan @agilgur5